Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingester: Support logging of samples EWMA CPU load is based on #5508

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jul 14, 2023

What this PR does

To help debugging, support logging of samples EWMA CPU load is based on when enabling read path limiting. I'm making this logging configurable, behind an experimental flag.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@aknuds1 aknuds1 added component/ingester enhancement New feature or request labels Jul 14, 2023
@aknuds1 aknuds1 marked this pull request as ready for review July 14, 2023 17:00
@aknuds1 aknuds1 requested a review from a team as a code owner July 14, 2023 17:00
@aknuds1 aknuds1 force-pushed the arve/log-source-samples branch 2 times, most recently from e8f55c9 to 417e4cd Compare July 18, 2023 12:07
@aknuds1 aknuds1 requested a review from a team as a code owner July 18, 2023 12:07
@aknuds1 aknuds1 changed the title Ingester: For debugging, log samples EWMA CPU load is based on Ingester: Support logging of samples EWMA CPU load is based on Jul 18, 2023
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just left a comment about the test.

pkg/util/limiter/utilization_test.go Outdated Show resolved Hide resolved
For debugging, log samples EWMA CPU load is based on when enabling read
path limiting. This should be removed again once we're done debugging.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 force-pushed the arve/log-source-samples branch 2 times, most recently from be1423e to 1dfe506 Compare July 19, 2023 08:37
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 enabled auto-merge (squash) July 19, 2023 11:55
@aknuds1 aknuds1 merged commit 59bd495 into main Jul 19, 2023
@aknuds1 aknuds1 deleted the arve/log-source-samples branch July 19, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ingester enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants