Allow ingesters to configure SpreadMinimizingTokenGenerator #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gester-ring Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
pracucci
approved these changes
Jun 22, 2023
pkg/ingester/ingester_ring.go
Outdated
| case randomTokenGeneration: | ||
| return ring.NewRandomTokenGenerator() | ||
| default: | ||
| warn := fmt.Sprintf("Unsupported token generation strategy (\"%s\") has been chosen for %s. RandomTokenGenerator will be used instead.", cfg.TokenGeneratorStrategy, tokenGenerationStrategyFlag) |
There was a problem hiding this comment.
[nit] Validate the TokenGeneratorStrategy configured value in RingConfig.Validate() instead, so that it's consistent with the rest of the config validation. No need to log it there, just return the error.
aknuds1
approved these changes
Jun 22, 2023
aknuds1
reviewed
Jun 22, 2023
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/spread-minimizing-tg
branch
from
e553475
to
46e6d70
Compare
pracucci
approved these changes
Jun 22, 2023
aknuds1
changed the title
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR introduces 2 experimental CLI flags to
ingester.RingConfig:token-generation-strategy: specifies the strategy used for generating tokens for ingesters. Possible values arerandom-tokens(default) andspread-min-tokens.spread-minimizing-zones: comma-separated list of zones in whichSpreadMinimizingTokenGeneratoris used for token generation. This configuration is used only whentoken-generation-strategyis set tospread-min-tokens.Which issue(s) this PR fixes or relates to
Part of #4736
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]