Store-gateway: disable index header verification #5174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR disables verifying the index header upon loading it. Reading the whole index header can be resource consuming. Verificaiton/checksumming reads the whole index header once in addition to the read to sample the index header. This change should effectively halve the time to load an index header since one of the reads will be skipped. pracucci suggested to make this configurable per-tenant. But the changes would involve changing 23 tests and 3 more production code usages. I'm not sure if the complexity is worth it at this point. I can extend the PR if reviewers think this change is incomplete. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
reviewed
Jun 5, 2023
pracucci
approved these changes
Jun 5, 2023
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
pracucci
approved these changes
Jun 5, 2023
dimitarvdimitrov
deleted the
dimitar/st-gw/disable-index-header-verification-on-load
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR disables verifying the index header upon loading it. Reading the whole index header can be resource consuming. Verification/checksumming reads the whole index header once in addition to the read to sample the index header. This change should effectively halve the time to load an index header since one of the reads will be skipped.
@pracucci suggested to make this configurable per-tenant. But the changes would involve changing 23 tests and 3 more production code usages. I'm not sure if the complexity is worth it at this point. I can extend the PR if reviewers think per-tenant configuration is necessary. IMO this configuration parameter depends on the hardware on which the store-gateway runs and the risk for all tenants is the same.
Which issue(s) this PR fixes or relates to
Related to #5046
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]