Disable HTTP timeout on block upload endpoint for uploading a file. #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Log errors sent back to client from file upload handler. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
…imeouts disabled. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
force-pushed
the
backfill-timeouts
branch
from
a30ab43
to
56a0ec0
Compare
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
changed the title
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pracucci
approved these changes
May 10, 2023
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Marco Pracucci <marco@pracucci.com>
Thank you for review! This test was @andyasp's idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables HTTP timeout values on compactor's endpoint for uploading a file for a block. This is done to allow uploads of big files.
In the future we may want to introduce minimum upload rate instead of just disabling timeout.
Note that block upload feature is disabled by default, and must be enabled for tenant to use it.
This PR also changes
/api/v1/upload/block/{block}/filesendpoint to allow upload of files with unsetContent-Length(chunked uploads).