Support native histograms in pkg/ruler #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
reviewed
Mar 6, 2023
pkg/ruler/manager.go
Outdated
| if err != nil { | ||
| // The only error we could get here is a context canceled. | ||
| return | ||
| for userID, ruleGroup := range ruleGroups { |
There was a problem hiding this comment.
I don't think this is correct. This was recently introduced.
There was a problem hiding this comment.
Thanks for catching it. Some mess with the merge. Re-synced the branches now and this diff is gone.
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
codesome
force-pushed
the
codesome/sync-ruler
branch
from
1a4bda6
to
b85f452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Syncs ruler changes from
sparsehistogrambranch.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]