Support histograms in pkg/frontend #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codesome
force-pushed
the
codesome/sync-frontend
branch
from
9a7cdc6
to
45eb1d4
Compare
codesome
force-pushed
the
codesome/sync-frontend
branch
from
45eb1d4
to
07a90ba
Compare
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
codesome
force-pushed
the
codesome/sync-frontend
branch
from
07a90ba
to
a2d3002
Compare
krajorama
reviewed
Mar 7, 2023
Generics double the time for running the filter due to using interface mechanism to get to the GetTimestampVal() function. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Turns out this takes double the time due to the function getting the timestamp being invoked through interface semantics in Go. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
3 tasks
# Conflicts: # pkg/frontend/querymiddleware/results_cache_test.go
pracucci
reviewed
Mar 9, 2023
| set = append(set, series.NewConcreteSeries(mimirpb.FromLabelAdaptersToLabels(stream.Labels), samples, nil)) | ||
| // same logic as samples above | ||
| histograms := make([]mimirpb.Histogram, 0) //, len(stream.Histograms)+10) | ||
| /* // for now we will disable query sharding for tenants who enable native histograms, as the changes to support query sharding with native histograms is non-trivial |
There was a problem hiding this comment.
I suggest to not merge commented code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Syncs that changes in
pkg/frontendfromsparsehistogrambranch.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]