Store gateway mmap removal: introduce Decbuf.Position() to simplify logic
#3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
I checked the offsets math and LGTM! Let's wait for @56quarters review too, since he knows this code better than me.
56quarters
approved these changes
Dec 22, 2022
pracucci
deleted the
charleskorn/mmap-less-index-header-reader-optimisation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR introduces a
Position()method toDecbuf. This allows us to remove a number of confusing calculations involving the remaining length of aDecbuf. (This is one example of the confusion the current implementation can cause.)I've tried to do this incrementally. I'd suggest reviewing each commit individually rather than trying to review the entire PR's changes in one go.
Which issue(s) this PR fixes or relates to
Relates to #3465, builds upon #3742.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]