Streaming store-gateway: add iterators for loading series from index #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
Base automatically changed from
dimitar/store-gateway-e2e-test-changes
to
main
December 5, 2022 14:42
dimitarvdimitrov
force-pushed
the
dimitar/upstream-index-loading-iterators
branch
from
e0dd8c9
to
e361abf
Compare
pracucci
approved these changes
Dec 5, 2022
| maxTime, | ||
| ) | ||
|
|
||
| limitingIterator := newLimitingSeriesChunkRefsSetIterator( |
There was a problem hiding this comment.
[non blocking] openBlockSeriesChunkRefsSetsIterator() is per block. This means that we apply the series limiter for every series and block. If the same series is queried from multiple blocks, then the series is double counted. This is the same behaviour we currently have in main so this is not a regression, but with the streaming store-gateway we have the opportunity the limiter up the stack and to actually apply on the merged series from all blocks. We can further discuss it and eventually do it in the working branch.
dimitarvdimitrov
force-pushed
the
dimitar/upstream-index-loading-iterators
branch
from
9a2eb66
to
dda7f44
Compare
dimitarvdimitrov
force-pushed
the
dimitar/upstream-index-loading-iterators
branch
from
dda7f44
to
5d313cd
Compare
We are adding three iterators: * `loadingSeriesChunkRefsSetIterator` is responsible for loading chunks from the index * `postingsSetsIterator` is responsible for batching postings so loading series from the index doesn't load all labels and chunk refs from the index in one go * `limitingSeriesChunkRefsSetIterator` is responsible for limiting series and chunks within a request We are also adding a function to set up these three iterators for an incoming Series() request for a block. Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
force-pushed
the
dimitar/upstream-index-loading-iterators
branch
from
5d313cd
to
808b3d8
Compare
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
force-pushed
the
dimitar/upstream-index-loading-iterators
branch
from
808b3d8
to
6f69220
Compare
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…rafana#3645) * Streaming store-gateway: add iterators for loading series from index We are adding three iterators: * `loadingSeriesChunkRefsSetIterator` is responsible for loading chunks from the index * `postingsSetsIterator` is responsible for batching postings so loading series from the index doesn't load all labels and chunk refs from the index in one go * `limitingSeriesChunkRefsSetIterator` is responsible for limiting series and chunks within a request We are also adding a function to set up these three iterators for an incoming Series() request for a block. Co-authored-by: Marco Pracucci <marco@pracucci.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update nolint directives Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Fix e2e testing interface used Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding three iterators:
loadingSeriesChunkRefsSetIteratoris responsible for loading chunksfrom the index
postingsSetsIteratoris responsible for batching postings so loadingseries from the index doesn't load all labels and chunk refs from the
index in one go
limitingSeriesChunkRefsSetIteratoris responsible for limitingseries and chunks within a request
We are also adding a function to set up these three iterators for an
incoming Series() request for a block (
openBlockSeriesChunkRefsSetsIterator).Co-authored-by: Marco Pracucci marco@pracucci.com
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov@grafana.com