Added ruler.tls-enabled configuration for alertmanager client
#3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustin170506
commented
Nov 11, 2022
pkg/ruler/notifier.go
Outdated
| } | ||
|
|
||
| func (cfg *NotifierConfig) RegisterFlags(f *flag.FlagSet) { | ||
| f.BoolVar(&cfg.TLSEnabled, "ruler.tls-enabled", true, "Enable TLS for gRPC client connecting to alertmanager-client.") |
There was a problem hiding this comment.
Do we need to validate the TLS flag when tls-enabled is enabled?
There was a problem hiding this comment.
It seems we didn't check it in other components. So I'll follow it.
Rustin170506
changed the title
tls_enabled flag for alertmanager_client configruler.tls-enabled configuration for alertmanager client
Rustin170506
force-pushed
the
rustin-patch-notifier-config
branch
from
c313d2e
to
6064583
Compare
Rustin170506
commented
Nov 24, 2022
|
Friendly ping @dimitarvdimitrov ~ |
dimitarvdimitrov
approved these changes
Nov 29, 2022
pracucci
reviewed
Dec 1, 2022
pracucci
reviewed
Dec 1, 2022
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
…ana#3432) * Add `tls_enabled` flag for `alertmanager_client` config * Update CHANGELOG.md * Update CHANGELOG.md * Address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add
tls_enabledflag foralertmanager_clientconfig.Which issue(s) this PR fixes or relates to
close #3220
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]