Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade upstream Alertmanager to reduce memory utilization and add discord support #3309

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

pracucci
Copy link
Collaborator

What this PR does

In this PR I'm upgrading the upstream Alertmanager to get another memory improvement I did in prometheus/alertmanager#3114 (I expect will reduce Alertmanager memory utilization by another -50% in a cluster with many tenants).

Since I'm upgrading the Alertmanager we're also getting other changes, in particular:

  • Added support for discord
  • VictorOps global victorops_api_key_file (not allowed in Mimir)
  • PagerDuty service_key_file and routing_key_file (not allowed in Mimir)

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…scord support

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from a team as a code owner October 26, 2022 09:35
@pracucci pracucci requested a review from gotjosh October 26, 2022 09:35
Copy link
Member

@JohnnyQQQQ JohnnyQQQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I pinged the alerting frontend team so they can eventually add the discord support in the UI.

Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 70d2fbe into main Oct 26, 2022
@pracucci pracucci deleted the reduce-alertmanager-memory branch October 26, 2022 10:52
masonmei pushed a commit to udmire/mimir that referenced this pull request Nov 4, 2022
…scord support (grafana#3309)

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
masonmei pushed a commit to udmire/mimir that referenced this pull request Nov 4, 2022
…scord support (grafana#3309)

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants