Query-frontend truncate the range queries at now + creation_grace_period #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colega
reviewed
Oct 10, 2022
Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com>
pracucci
reviewed
Oct 10, 2022
There was a problem hiding this comment.
Thanks for working on this! ❤️
Similarly to what we did in https://github.com/grafana/mimir/pull/3134/files#diff-1e0a07c0c1ea87ab5a582d79c587a73a9b8e0680d89c61d5c94be106823a4a4e could you update the creation grace period description to mention that it's also used by query-frontend too? You can look at the PR #3134 for reference.
pracucci
reviewed
Oct 10, 2022
pracucci
reviewed
Oct 10, 2022
Rustin170506
commented
Oct 11, 2022
Rustin170506
requested review from
colega and
pracucci
and removed request for
colega
Rustin170506
commented
Oct 11, 2022
colega
reviewed
Oct 11, 2022
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| ### Grafana Mimir | |||
|
|
|||
| * [CHANGE] Query-frontend: truncate queries based on the configured creation grace period (`--validation.create-grace-period`) to avoid querying too far into the future. #3172 | |||
There was a problem hiding this comment.
I would say this is an ENHANCEMENT, not a CHANGE, as per https://github.com/grafana/mimir/blob/main/docs/internal/contributing/README.md#changelog
|
Thanks for your review! 💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Query-frontend truncate the range queries at now + creation_grace_period. See more: #3144 (comment)
Which issue(s) this PR fixes or relates to
close #3144
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]