Removed configdb support from Ruler and Alertmanager backends #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pstibrany
approved these changes
Jul 19, 2021
| @@ -13,9 +13,9 @@ Cortex Alertmanager notification setup follow mostly the syntax of Prometheus Al | |||
|
|
|||
| With the introduction of Cortex 1.8 the storage backend config option shifted to the new pattern [#3888](https://github.com/cortexproject/cortex/pull/3888). You can find the new configuration [here](../configuration/config-file-reference.md#alertmanager_storage_config) | |||
|
|
|||
| Note that when using `-alertmanager.sharding-enabled=true`, the following storage backends are not supported: `local`, `configdb`. | |||
| Note that when using `-alertmanager.sharding-enabled=true`, the following storage backends are not supported: `local`. | |||
There was a problem hiding this comment.
super-nit: change the clause to singular? ("the following storage backend is not supported: local")
There was a problem hiding this comment.
this is not imporant, ignore.
dimitarvdimitrov
added a commit
that referenced
this pull request
Jan 20, 2022
The API was removed by #15, so the docs need to be updated as well.
2 tasks
pracucci
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Remove configs API from API docs. The API was removed by #15, so the docs need to be updated as well. * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Reformat table in api docs Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update table in docs Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Today I've spent a good 10 minutes to review changes related to configdb in #4. Since configdb is deprecated, would be nice if we could remove it completely in Mimir. This PR does that.
Thoughts?
Which issue(s) this PR fixes:
Fixes #10
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]