-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed configdb support from Ruler and Alertmanager backends #15
Conversation
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, lgtm.
@@ -13,9 +13,9 @@ Cortex Alertmanager notification setup follow mostly the syntax of Prometheus Al | |||
|
|||
With the introduction of Cortex 1.8 the storage backend config option shifted to the new pattern [#3888](https://github.com/cortexproject/cortex/pull/3888). You can find the new configuration [here](../configuration/config-file-reference.md#alertmanager_storage_config) | |||
|
|||
Note that when using `-alertmanager.sharding-enabled=true`, the following storage backends are not supported: `local`, `configdb`. | |||
Note that when using `-alertmanager.sharding-enabled=true`, the following storage backends are not supported: `local`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super-nit: change the clause to singular? ("the following storage backend is not supported: local
")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not imporant, ignore.
The API was removed by #15, so the docs need to be updated as well.
* Remove configs API from API docs. The API was removed by #15, so the docs need to be updated as well. * Update CHANGELOG.md Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Reformat table in api docs Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> * Update table in docs Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
What this PR does:
Today I've spent a good 10 minutes to review changes related to configdb in #4. Since configdb is deprecated, would be nice if we could remove it completely in Mimir. This PR does that.
Thoughts?
Which issue(s) this PR fixes:
Fixes #10
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]