Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimir: assert on unexpected value in ingester_partitions_shard_size #10746

Merged
merged 2 commits into from
Feb 27, 2025
Merged

mimir: assert on unexpected value in ingester_partitions_shard_size #10746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
827b54f
mimir: validate $._config.shuffle_sharding.ingester_partitions_shard_…
narqo Feb 26, 2025
7c1a319
update changelog
narqo Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
* `querier_topology_spread_max_skew`
* `ruler_topology_spread_max_skew`
* `ruler_querier_topology_spread_max_skew`
* [ENHANCEMENT] Validate the `$._config.shuffle_sharding.ingester_partitions_shard_size` value when partition shuffle sharding is enabled in the ingest-storage mode. #10746
* [BUGFIX] Ports in container rollout-operator. #10273
* [BUGFIX] When downscaling is enabled, the components must annotate `prepare-downscale-http-port` with the value set in `$._config.server_http_port`. #10367

Expand Down
6 changes: 6 additions & 0 deletions operations/mimir/shuffle-sharding.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@
shuffle_sharding_enabled &&
$._config.shuffle_sharding.ingest_storage_partitions_enabled,

// ingester_shard_size is expected to be multi-zone ready, so here we divide its value by 3 (the assumed RF) to get ingester_partitions_shard_size.
// When the partitions sharding becomes the default, the "ingester_shard_size" configuration will be a noop, so this assertion can be removed.
assert !partitions_shuffle_sharding_enabled ||
($._config.shuffle_sharding.ingester_partitions_shard_size == $._config.shuffle_sharding.ingester_shard_size / 3)
: 'with $._config.shuffle_sharding.ingest_storage_partitions_enabled, "ingester_partitions_shard_size" must be equal to "ingester_shard_size / 3"',

local roundUpToMultipleOfThree(n) = std.ceil(n / 3) * 3,

// The ingesters shard size has been computed this way:
Expand Down
Loading