Fix OOO counter reset test #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionaliao
merged commit 0ef4562
into
cedwards/ooo-native-histograms
4 of 6 checks passed
carrieedwards
pushed a commit
that referenced
this pull request
Jan 9, 2024
carrieedwards
pushed a commit
that referenced
this pull request
Jan 9, 2024
fionaliao
added a commit
that referenced
this pull request
Jan 19, 2024
fionaliao
added a commit
that referenced
this pull request
Jan 23, 2024
fionaliao
added a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test was failing due to
814 observations found in buckets, but the Count field is 1000: histogram's observation count should equal the number of observations found in the buckets (in absence of NaN). Updated test to generate a valid histogram for each sample rather than just updating the count.