Add multiple encoding test #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrieedwards
force-pushed
the
cedwards/ooo-native-histograms
branch
4 times, most recently
from
b02a0e9
to
fab5b45
Compare
fionaliao
force-pushed
the
fl/add-multiple-encoding-tests
branch
from
46bbef3
to
cf744ab
Compare
carrieedwards
approved these changes
Jan 16, 2024
fionaliao
added a commit
that referenced
this pull request
Jan 19, 2024
fionaliao
added a commit
that referenced
this pull request
Jan 23, 2024
fionaliao
added a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for when a series has samples with multiple encodings, including when the samples are out of order. Note that the behaviour is a bit weird when multiple encodings are committed together - float samples are always processed before histogram ones so sometimes histograms are marked as OOO when you might not expect them to be - see test comments for more details. I don't think this behaviour is worth changing as it shouldn't happen very often.