-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for counter resets when compacting ooo native histograms #574
Merged
fionaliao
merged 2 commits into
cedwards/ooo-native-histograms
from
fl/counter-reset-compactor-test-after-fix
Dec 21, 2023
Merged
Add test for counter resets when compacting ooo native histograms #574
fionaliao
merged 2 commits into
cedwards/ooo-native-histograms
from
fl/counter-reset-compactor-test-after-fix
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carrieedwards
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test seems very thorough. Great job!
fionaliao
force-pushed
the
fl/counter-reset-compactor-test-after-fix
branch
from
December 21, 2023 15:09
f84d2d5
to
ec779e0
Compare
fionaliao
merged commit Dec 21, 2023
27ba5d3
into
cedwards/ooo-native-histograms
2 of 6 checks passed
carrieedwards
pushed a commit
that referenced
this pull request
Jan 8, 2024
* Add test for ooo histogram compaction Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
carrieedwards
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Add test for ooo histogram compaction Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
carrieedwards
pushed a commit
that referenced
this pull request
Jan 9, 2024
* Add test for ooo histogram compaction Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
fionaliao
added a commit
that referenced
this pull request
Jan 19, 2024
* Add test for ooo histogram compaction Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
fionaliao
added a commit
that referenced
this pull request
Jan 23, 2024
* Add test for ooo histogram compaction Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
fionaliao
added a commit
that referenced
this pull request
Feb 5, 2024
* Add test for ooo histogram compaction Signed-off-by: Fiona Liao <fiona.y.liao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.