Expand OOO native histogram tests to include gauge histograms #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fionaliao
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Adding gauge scenarios to sampleTypeScenarios looks good to me, I do have a comment about refactoring requireEqualSamples which I think is worth doing in this PR. Also I think it's worth rebasing the ooo-native-histograms branch as the requireEqualSamples function signature has changed (a ignoreCounterResets parameter was added in #565)
carrieedwards
force-pushed
the
cedwards/ooo-native-histograms-gauge-tests
branch
from
8c5c98d
to
374a762
Compare
fionaliao
approved these changes
Nov 21, 2023
carrieedwards
merged commit 86a2683
into
cedwards/ooo-native-histograms
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands OOO native histogram tests to include testing for gauge-type histograms. This is to check that gauge histograms, which do not have counter resets, are handled properly, with the correct CounterResetHint of histogram.Gauge type.