Adding more buckets to loki_memcache_request_duration_seconds histogram #9431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2023 16:47
We are now using extstore (with NVMe drives) so latenct can be higher than the ~250ms max Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
force-pushed
the
dannykopping/add-memcached-req-buckets
branch
from
d511464 to
c190dd8
Compare
dannykopping
commented
May 9, 2023
| @@ -65,8 +65,13 @@ func NewMemcached(cfg MemcachedConfig, client MemcachedClient, name string, reg | |||
| Namespace: "loki", | |||
| Name: "memcache_request_duration_seconds", | |||
| Help: "Total time spent in seconds doing memcache requests.", | |||
| // Memcached requests are very quick: smallest bucket is 16us, biggest is 1s | |||
There was a problem hiding this comment.
This was wrong; the max was ~250ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Users using extstore (with NVMe drives) may experience latencies higher than the ~250ms max as previously defined.