Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: Add HTTP API to change the log level at runtime #9357

Merged
merged 12 commits into from
May 25, 2023

Conversation

Indransh
Copy link
Contributor

@Indransh Indransh commented May 1, 2023

What this PR does / why we need it:
To be able to change the log level at runtime, particularly from info to debug to enable debugging information during an incident without restarting Loki.

Which issue(s) this PR fixes:
Fixes #6805

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md: No such changes

@CLAassistant
Copy link

CLAassistant commented May 1, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label May 1, 2023
@Indransh Indransh marked this pull request as ready for review May 1, 2023 14:51
@Indransh Indransh requested review from JStickler and a team as code owners May 1, 2023 14:51
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[docs team] I added a few wording suggestions to capture some context from the original issue.

docs/sources/api/_index.md Outdated Show resolved Hide resolved
docs/sources/api/_index.md Outdated Show resolved Hide resolved
Indransh and others added 3 commits May 3, 2023 19:02
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
@Indransh Indransh requested a review from JStickler May 3, 2023 17:29
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] LGTM
Thanks for the contribution.

@MasslessParticle
Copy link
Contributor

@Indransh Can you fix the merge conflicts? After that, we're good to merge

@Indransh
Copy link
Contributor Author

@Indransh Can you fix the merge conflicts? After that, we're good to merge

@MasslessParticle Done.

@MichelHollands MichelHollands merged commit a554047 into grafana:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change log level at runtime
5 participants