(chore): remove incorrect cache config preample #8859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of the config generation tool, a comment prefix was added for all cache types The likely explanation is that we have 4 different cache types who all register the same flags, and the last one got precedence Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
github-actions
bot
added
the
type/docs
|
Hello @dannykopping!
Please, if the current pull request addresses a bug fix, label it with the |
dannykopping
added
type/docs
grafanabot
pushed a commit
that referenced
this pull request
Mar 22, 2023
With the addition of the [config generation tool](#7916), a comment prefix was added for all cache types: `Cache config for index entry writing.` https://grafana.com/docs/loki/next/configuration/#cache_config This appears in the description of each cache config option, and is misleading. (cherry picked from commit 2d93952)
dannykopping
pushed a commit
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the config generation tool, a comment prefix was added for all cache types:
Cache config for index entry writing.https://grafana.com/docs/loki/next/configuration/#cache_config
This appears in the description of each cache config option, and is misleading.
The likely explanation is that we have 4 different cache types who all register the same flags, and the last one got precedence
I noticed this while reviewing #8852.