Loki: add a 'since' query parameter for easier querying using relative time #7964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
pkg/logql/downstream_test.go
Outdated
Comment on lines
37
to
51
| //{`1`, false}, | ||
| //{`1 + 1`, false}, | ||
| //{`{a="1"}`, false}, | ||
| //{`{a="1"} |= "number: 10"`, false}, | ||
| //{`rate({a=~".+"}[1s])`, false}, | ||
| //{`sum by (a) (rate({a=~".+"}[1s]))`, false}, | ||
| //{`sum(rate({a=~".+"}[1s]))`, false}, | ||
| //{`max without (a) (rate({a=~".+"}[1s]))`, false}, | ||
| //{`count(rate({a=~".+"}[1s]))`, false}, | ||
| //{`avg(rate({a=~".+"}[1s]))`, true}, | ||
| //{`avg(rate({a=~".+"}[1s])) by (a)`, true}, | ||
| //{`1 + sum by (cluster) (rate({a=~".+"}[1s]))`, false}, | ||
| //{`sum(max(rate({a=~".+"}[1s])))`, false}, | ||
| //{`max(count(rate({a=~".+"}[1s])))`, false}, | ||
| //{`max(sum by (cluster) (rate({a=~".+"}[1s]))) / count(rate({a=~".+"}[1s]))`, false}, |
There was a problem hiding this comment.
Why are these commented out?
There was a problem hiding this comment.
ugh, had some stuff on my working directory I didn't notice when I made this... fixed..
… range Signed-off-by: Edward Welch <edward.welch@grafana.com>
slim-bean
force-pushed
the
since-parameter
branch
from
84e22cc to
430b961
Compare
Signed-off-by: Edward Welch <edward.welch@grafana.com>
|
./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
DylanGuedes
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Welch edward.welch@grafana.com
What this PR does / why we need it:
logcli has a command line parameter called
sincewhich makes it easy to query logs relative to the current time, however this is some syntactic sugar used in logcli to calculatestartandendquery parameters for the query sent to Loki.This PR adds native support for a
sincequery parameter to make it a little easier to consume the Loki query API without having to calculate precise start/end times with every request.This is useful if you are polling the Loki API from a third party app which doesn't let you easily build dynamic URL's and all you want to do is poll for say the last 3 hours of logs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguideCHANGELOG.mdupdateddocs/sources/upgrading/_index.md