-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(embedded-cache): Add missing docs on config page. #7684
Conversation
126cf31
to
f2ccd8c
Compare
f2ccd8c
to
40265c2
Compare
Adds `embedded-cache` config under `cache_config` section. Also adds message about deprecation of `fifocache`
40265c2
to
3fb5d12
Compare
./tools/diff_coverage.sh ../loki-target-branch/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
**What this PR does / why we need it**: Adds `embedded-cache` config under `cache_config` section. Also adds message about deprecation of `fifocache` **Which issue(s) this PR fixes**: Fixes #7677 **Special notes for your reviewer**: **Checklist** - [x] Documentation added - [x] `CHANGELOG.md` updated (cherry picked from commit 7073ea8)
**What this PR does / why we need it**: Adds `embedded-cache` config under `cache_config` section. Also adds message about deprecation of `fifocache` **Which issue(s) this PR fixes**: Fixes grafana#7677 **Special notes for your reviewer**: **Checklist** - [x] Documentation added - [x] `CHANGELOG.md` updated
What this PR does / why we need it:
Adds
embedded-cache
config undercache_config
section. Also adds message about deprecation offifocache
Which issue(s) this PR fixes:
Fixes #7677
Special notes for your reviewer:
Checklist
CHANGELOG.md
updated