Loki: Set querier worker max concurrent regardless of run configuration. #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Nov 16, 2021
trevorwhitney
pushed a commit
to trevorwhitney/loki
that referenced
this pull request
Jan 27, 2022
…on. (grafana#4761) * always set the querier worker MaxConcurrentRequests * removing a test which doesn't apply as this setting isn't being set in worker_service.go anymore (cherry picked from commit 88ef940)
cyriltovena
pushed a commit
that referenced
this pull request
Feb 1, 2022
…nfigurati… (#5256) * Loki: Set querier worker max concurrent regardless of run configuration. (#4761) * always set the querier worker MaxConcurrentRequests * removing a test which doesn't apply as this setting isn't being set in worker_service.go anymore (cherry picked from commit 88ef940) * update vendor * update vendor again, but better? Co-authored-by: Ed Welch <edward.welch@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Be sure to set MaxConcurrentRequests when initializing the querier.
Which issue(s) this PR fixes:
Fixes #4760
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.