Promtail Kafka target #4568
Promtail Kafka target #4568
Conversation
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Still needs to finish tests. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
| @@ -182,7 +182,7 @@ You can relabel default labels via [Relabeling](#relabeling) if required. | |||
| Providing a path to a bookmark is mandatory, it will be used to persist the last event processed and allow | |||
| resuming the target without skipping logs. | |||
|
|
|||
| see the [configuration](./configuration.md#windows_events) section for more information. | |||
| see the [configuration](https://grafana.com/docs/loki/latest/clients/promtail/configuration/#windows_events) section for more information. | |||
There was a problem hiding this comment.
@KMiller-Grafana Not sure how we should proceed with those link, but previously it would not work on the website.
We could use relref short code but this means it doesn't work on github since it's only supported for hugo and not markdown.
In the meantime I've replace it with an absolute link, which might not respect the version sadly.
WDYT ? I don't think we should block the review because of this though, let take care of it later if needed.
There was a problem hiding this comment.
Ugh, ./configuration.md#windows_events doesn't work? I wonder if it has to do with _ (using spaces creates links with -). Anyways, it's definitely preferable to use the local links as it allows the site generation tool to create entire sections of the docs for different releases and not always point to latest.
| "__topic": model.LabelValue(claim.Topic()), | ||
| "__partition": model.LabelValue(fmt.Sprintf("%d", claim.Partition())), | ||
| "__member_id": model.LabelValue(session.MemberID()), | ||
| "__group_id": model.LabelValue(ts.cfg.KafkaConfig.GroupID), |
There was a problem hiding this comment.
Should these be further prefixed with __meta_kafka, like we have for __meta_kubernetes_<etc>?
| @@ -182,7 +182,7 @@ You can relabel default labels via [Relabeling](#relabeling) if required. | |||
| Providing a path to a bookmark is mandatory, it will be used to persist the last event processed and allow | |||
| resuming the target without skipping logs. | |||
|
|
|||
| see the [configuration](./configuration.md#windows_events) section for more information. | |||
| see the [configuration](https://grafana.com/docs/loki/latest/clients/promtail/configuration/#windows_events) section for more information. | |||
There was a problem hiding this comment.
Ugh, ./configuration.md#windows_events doesn't work? I wonder if it has to do with _ (using spaces creates links with -). Anyways, it's definitely preferable to use the local links as it allows the site generation tool to create entire sections of the docs for different releases and not always point to latest.
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
What this PR does / why we need it:
This PR introduce Kafka support for Promtail. This is just a Draft PR because I'm still working on the documentation and testing.
But I still wanted to give more visibility to the team in the meantime.
Which issue(s) this PR fixes:
Fixes #4537
Special notes for your reviewer:
Checklist