Enable fifo cache by default #4471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
2 tasks
|
I'm continuing Mauro's work at this PR. |
|
Closing (PR 4519 merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make sure that there is always at least one cache configured for the chunks cache. This enables the FIFO cache by default if no other cache is configured.
Furthermore, it also sets defaults for the cache
validityand the FIFO cache'smax-size-bytes. The default of1GBformax-size-bytesis set relatively low because setting this value too low results in bad query performance, setting it too high results in OOM, I'd consider bad query performance preferable over OOM so it's better to err on the low side.