Fixes the pattern parser validation. #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should never have 2 consecutive capture, since when we do we can't figure which data goes where. The previous validation was validating two nodes at the time and moving to the next two nodes so in the end it wasn't validating properly. :facepalm: Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
owen-d
pushed a commit
to owen-d/loki
that referenced
this pull request
Sep 13, 2021
We should never have 2 consecutive capture, since when we do we can't figure which data goes where. The previous validation was validating two nodes at the time and moving to the next two nodes so in the end it wasn't validating properly. :facepalm: Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Merged
owen-d
pushed a commit
to owen-d/loki
that referenced
this pull request
Sep 13, 2021
We should never have 2 consecutive capture, since when we do we can't figure which data goes where. The previous validation was validating two nodes at the time and moving to the next two nodes so in the end it wasn't validating properly. :facepalm: Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Merged
owen-d
added a commit
that referenced
this pull request
Sep 13, 2021
We should never have 2 consecutive capture, since when we do we can't figure which data goes where. The previous validation was validating two nodes at the time and moving to the next two nodes so in the end it wasn't validating properly. :facepalm: Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
owen-d
added a commit
that referenced
this pull request
Sep 13, 2021
We should never have 2 consecutive capture, since when we do we can't figure which data goes where. The previous validation was validating two nodes at the time and moving to the next two nodes so in the end it wasn't validating properly. :facepalm: Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never have 2 consecutive capture, since when we do we can't figure which data goes where.
The previous validation was validating two nodes at the time and moving to the next two nodes so in the end it wasn't validating properly.
I've also took the opportunity to improve the error message to make it easier to spot the problem.
🤦
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com