Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix build version info #4135

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Build: Fix build version info #4135

merged 1 commit into from
Aug 10, 2021

Conversation

slim-bean
Copy link
Collaborator

When the build package was refactored the Makefile was not updated, this PR fixes this.

Fixes #4115
Fixes #4133

@slim-bean slim-bean requested a review from a team as a code owner August 10, 2021 21:10
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Are we going to republish v2.3.0 based on this?

@slim-bean
Copy link
Collaborator Author

Are we going to republish v2.3.0 based on this?

Republishing tends to cause more trouble than good given that we have hashes out already for the released binaries.

Instead we should do this in a 2.3.1 but I don't think this alone warrants a patcthfix release.

@slim-bean slim-bean merged commit 1a970c5 into main Aug 10, 2021
@slim-bean slim-bean deleted the build-info branch August 10, 2021 21:19
@Abuelodelanada
Copy link

Thank you very much for this PR @slim-bean
Do you know when this fix will be released?

@glassbeads
Copy link

Please bear in mind that the automation that people use (Ansible, Puppet etc) may depend on binary version information - like "update the binary if the version differs". So issues like this may break it for everyone, and fixing it from users' side involves a lot of manual work.

@cedsana
Copy link

cedsana commented Dec 9, 2022

I don't know if it's related but the version information don't contain the version number anymore:

$ promtail --version
promtail, version HEAD-1b627d8 (branch: HEAD, revision: 1b627d880)
  build user:       root@079d888186e6
  build date:       2022-11-10T23:52:44Z
  go version:       go1.19.2
  platform:         linux/arm64

The HEAD-1b627d8 part should be 2.7.0 and it's causing issues with Ansible automation.

This binary is directly taken from https://github.com/grafana/loki/releases/download/v2.7.0/promtail-linux-arm64.zip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants