Update cortex vendoring #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you need to rebuild the protos and check them in. |
|
@tomwilkie does it possible that cortex authors push proto generated files to it repo? it hard to check godoc and use it like this.. |
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
update-vendoring
branch
from
f896604
to
c35facb
Compare
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve
force-pushed
the
update-vendoring
branch
from
afe707f
to
9330f31
Compare
Merged
|
@vtolstov Yeah we should do that. |
tomwilkie
approved these changes
Mar 15, 2019
periklis
pushed a commit
to periklis/loki
that referenced
this pull request
Jul 16, 2024
[release-5.9] Backport PR grafana#13450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates it to latest master.