Implementing line comments #3126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tests Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
added 2 commits
January 6, 2021 09:42
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
owen-d
reviewed
Jan 6, 2021
| { | ||
| in: `#{app="foo"} | json`, | ||
| err: ParseError{msg: "syntax error: unexpected $end", line: 1, col: 20}, | ||
| }, |
There was a problem hiding this comment.
How does {app="foo"} |= "#" result? Can we add a test for this (I'm not sure if this would be interpreted correctly as a filter expression or incorrectly as a comment.
There was a problem hiding this comment.
That's a good idea - I've added some further tests to this end
added 3 commits
January 6, 2021 16:06
…xed as a comment Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Done and done good sir 👍 |
owen-d
approved these changes
Jan 7, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements line comments using the
#character.Which issue(s) this PR fixes:
Fixes #3112
Special notes for your reviewer:
I have not yet added documentation because it doesn't seem like we publish the LogQL grammar in the docs, and it feels a bit silly to document a line comment 🙃
Checklist