fix query intervals when running boltdb-shipper in single binary #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When running boltdb-shipper in single binary mode, we also make ingesters do the store query. We build a non-overlapping query interval for ingester and store query. While building ingester query, instead of clamping the start time of query to ingesters max look back period, I was setting the start time of the query to the max look back period which was causing more logs to be fetched than queried for.
While there were tests to check it, the tests were wrong too because instead of comparing unix timestamp I was comparing value returned by time.Second. This PR also takes care of fixing the tests.
Which issue(s) this PR fixes:
Fixes #2816
Checklist