Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

grafana / loki Public

Notifications You must be signed in to change notification settings
Fork 3.5k
Star 24.4k

Code
Issues 1.6k
Pull requests 261
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Promtail: Fix deadlock on tailer shutdown.#2717

Merged

slim-bean merged 12 commits intomastergrafana/loki:masterfrom promtail-tailer-clean-exitgrafana/loki:promtail-tailer-clean-exitCopy head branch name to clipboard

Oct 4, 2020

+128-52

Conversation Commits12 (12)Checks Files changed

Commits

Commits on Oct 3, 2020

to avoid a deadlock on shutdown, leave the goroutine running which reads the Lines channel from the tailer and it will exit when the tailer closes the channel.
slim-bean
committed
remove the flag I added a few weeks ago and instead when updating the position information of the file gracefully fail if the file no longer exists.
slim-bean
committed
update the vendoring of the tail library, more re-work on how tailing shutdown and errors are handled.
slim-bean
committed
fix mistake
slim-bean
committed
updating tail lib to merged commit hash
slim-bean
committed
go mod tidy
slim-bean
committed

Commits on Oct 4, 2020

update tail library with additional mutex lock
slim-bean
committed
break up the tailer goroutine into two separate goroutines to make it a little more clear and remove some special case logic.
slim-bean
committed
don't forget to close your channels!
slim-bean
committed
make the stop method in the tailer only execute at most one time.
slim-bean
committed
update hp-tail again with improvements to the mutex locking in closeFile
slim-bean
committed
replace the more complicated channel based single execution code with a sync.Once
slim-bean
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.