Add config options for loki dashboards #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2617 +/- ##
==========================================
+ Coverage 62.87% 62.90% +0.02%
==========================================
Files 170 170
Lines 15049 15049
==========================================
+ Hits 9462 9466 +4
+ Misses 4826 4823 -3
+ Partials 761 760 -1
|
periklis
force-pushed
the
loki-mixin-dashboards
branch
2 times, most recently
from
f9958e7 to
d6b589b
Compare
periklis
force-pushed
the
loki-mixin-dashboards
branch
from
d6b589b to
4c00db5
Compare
periklis
changed the title
periklis
force-pushed
the
loki-mixin-dashboards
branch
10 times, most recently
from
7671891 to
14e1a6c
Compare
periklis
changed the title
periklis
force-pushed
the
loki-mixin-dashboards
branch
from
14e1a6c to
70cafa5
Compare
periklis
changed the title
periklis
force-pushed
the
loki-mixin-dashboards
branch
6 times, most recently
from
1718a52 to
215fc02
Compare
periklis
force-pushed
the
loki-mixin-dashboards
branch
from
215fc02 to
e004609
Compare
owen-d
approved these changes
Sep 16, 2020
| assert (cfg.namespaceType == 'custom' || cfg.namespaceType == 'query') : "Only types 'query' and 'custom' are allowed for dashboard variable 'namespace'", | ||
|
|
||
| matchers:: { | ||
| ingester: [utils.selector.re('job', '($namespace)/ingester')], |
There was a problem hiding this comment.
nit: I think this can be an equality match instead of a regexp.
There was a problem hiding this comment.
I assume so, but I kept the same selectors as previously used for now. It is already a massive change :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses missing reconfigurability for Loki dashboards. It provides the following options:
Dashboards to adapt:
Which issue(s) this PR fixes:
Fixes #1830 and supersedes #1978
Special notes for your reviewer:
Checklist
/cc @cyriltovena @slim-bean