Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/promtail yaml config #2471

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 6, 2020

Fixes a bug with promtail config not implementing Cloneable, which caused it to be un-loadable. We now require the Cloneable interface on many parsing functions as a compile time check.

@owen-d owen-d force-pushed the fix/promtail-yaml-config branch from 0966e1c to dcb0674 Compare August 6, 2020 14:31
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owen-d owen-d force-pushed the fix/promtail-yaml-config branch from dcb0674 to a81a0df Compare August 6, 2020 14:49
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 6, 2020
@owen-d owen-d merged commit 05e0e91 into grafana:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants