Loki Canary: One more round of improvements to query for missing websocket entries up to max-wait #2369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
wait
set to only 1 min when we miss a websocket entry we check for it after 1 minute but only check one time.If promtail was delayed or another hiccup existed somewhere the entry could still make it but later.
This PR introduces
max-wait
where the canary will continue to check for missing entries up to this time before officially marking them lost.There was also a repeating pattern of removing elements from a slice which I extracted into a dedicated function for better reuse