Skip to content

fix: make helm use grpc for compactor address #17454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rurod
Copy link

@rurod rurod commented Apr 25, 2025

What this PR does / why we need it:
Align the computation logic of the compactor address with how other address are computed.
Moreover, it makes use of grpc, as according to the Loki codebase, it's the preferred way :
https://github.com/grafana/loki/blob/46b2271aacd26734979667da61d5c9d24a8efb2b/pkg/loki/modules.go#L1256C1-L1274C2

Which issue(s) this PR fixes:
Kind of fixes #17100, as using the full hostname of the service rather than the short name helps comply with the no_proxy instruction, even if not mandatory

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@rurod rurod requested a review from a team as a code owner April 25, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant