chore: remove copied loop vars #14383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorwhitney
requested review from
periklis,
xperimental,
JoaoBraveCoding and
a team
as code owners
cstyan
approved these changes
Oct 4, 2024
| @@ -81,7 +81,7 @@ func (r *dynamodbIndexReader) ReadIndexEntries(ctx context.Context, tableName st | |||
| var readerGroup errgroup.Group | |||
| // Start a goroutine for each processor | |||
| for i, processor := range processors { | |||
| segment, processor := i, processor // https://golang.org/doc/faq#closures_and_goroutines | |||
| segment := i | |||
There was a problem hiding this comment.
hmm, I wasn't sure if the rename was significant, but looks like that variable is only read so I'll change this one too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Go 1.22 fixed the need to copy loop vars. As a result, the
exportloopreflinter was removed, and replaced with one that checks for copied loop vars. This PR updates ourgolangci-lintto use the new linter and removes all the copied loop vars it found.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR