Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k214] fix: panic when parsing and extracting JSON key values #13791

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 5ef83a7 from #13790


What this PR does / why we need it:

This fixes a panic when parsing end extracting values from JSON log lines with keys that consist entirely of whitespaces.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.

@grafanabot grafanabot requested a review from a team as a code owner August 7, 2024 17:00
@grafanabot grafanabot added backport size/M type/bug Somehing is not working as expected labels Aug 7, 2024
@grafanabot grafanabot requested a review from na-- August 7, 2024 17:00
@MasslessParticle MasslessParticle merged commit 5b91719 into k214 Aug 7, 2024
65 checks passed
@MasslessParticle MasslessParticle deleted the backport-13790-to-k214 branch August 7, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants