-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker install doc #1227
Add docker install doc #1227
Conversation
@slim-bean @rfratto @cyriltovena @sh0rez mind hava a look? |
+1 |
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
@slim-bean @rfratto @cyriltovena @sh0rez mind hava a look? |
Personally, I would drop the After all, not even I guess what could work fine:
|
My last company ran all their production containers off of a docker-compose file :) I get your point, though. I do see value in this in general, if only for documenting how to do it for future contributors or for quickly trying out Loki for evaluation purposes. We should add a disclaimer to the top of the file to note that we don't recommend using pure Docker or docker-compose in production. |
Signed-off-by: Xiang Dai <764524258@qq.com>
3178dd5
to
1ed41d7
Compare
ping @rfratto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Just a few more comments.
I double checked that Docker refers to Docker Compose without the hyphen, this seems to be true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix #1210
Signed-off-by: Xiang Dai 764524258@qq.com