Skip to content

Commit

Permalink
ksonnet/loki: Add gRPC port to compactor mixin (#8855)
Browse files Browse the repository at this point in the history
**What this PR does / why we need it**:

Problem: in #7804 the possibility to use gRPC for communicating with the compactor for query time filtering of data requested for deletion was added, however, the Loki mixin still generates the compactor service without a gRPC port.

Solution: make the compactor service/deployment expose both an HTTP and gRPC port.

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
  • Loading branch information
JoaoBraveCoding authored Mar 21, 2023
1 parent b502ee2 commit cb8a744
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
#### Jsonnet

* [7923](https://github.com/grafana/loki/pull/7923) **manohar-koukuntla**: Add zone aware ingesters in jsonnet deployment
* [8855](https://github.com/grafana/loki/pull/8855) **JoaoBraveCoding**: Add gRPC port to loki compactor mixin

##### Fixes

Expand Down
4 changes: 1 addition & 3 deletions production/ksonnet/loki/boltdb_shipper.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@
target: 'compactor',
} else {},

compactor_ports: [
containerPort.new(name='http-metrics', port=$._config.http_listen_port),
],
compactor_ports:: $.util.defaultPorts,

compactor_container:: if $._config.using_boltdb_shipper then
container.new('compactor', $._images.compactor) +
Expand Down

0 comments on commit cb8a744

Please sign in to comment.