Improve comparison by using internal typescript methods #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction, function parameteres and classes
academo
requested review from
mckn,
jackw and
leventebalogh
and removed request for
a team and
mckn
academo
commented
Feb 29, 2024
academo
commented
Feb 29, 2024
academo
commented
Feb 29, 2024
academo
commented
Feb 29, 2024
academo
commented
Mar 1, 2024
There was a problem hiding this comment.
big fixture file extracted from a grafana/ui PR to test an edge case
academo
commented
Mar 1, 2024
There was a problem hiding this comment.
big fixture file extracted from a grafana/ui PR to test an edge case
byronholldorf
added a commit
to HewlettPackard/hpe-grafana-clusterview-panel
that referenced
this pull request
Mar 21, 2024
initial clusterview plugin cleaned up for public release. compatibility check failing due to bug. Expected to be fixed shortly grafana/levitate#433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is similar to #361 but it doesn't put all the trust in the typescript internal checker.
In the previous PR, the internal ts checker would report errors between two identical packages because of internal ts nuances that created fake incompatible types.
The newer approach is to trust the typescript internal methods if it says two types are compatible but, if it says they are not, we always fallback to text comparison.
Additionally I added a test case to track an edge case with typescript autogenerated types suffixes.
Which issue(s) this PR fixes:
It closes #380
Fixes #
Special notes for your reviewer: