k6-core update for k6 browser version 2's sync API #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The k6 browser API is now Async. To continue to work with the sync API, k6-core needs to be updated to browser.NewSync. This method maps the browser's core API to sync methods.
inancgumus
requested review from
oleiade,
codebien,
mstoykov and
ankur22
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3782 +/- ##
==========================================
- Coverage 71.88% 71.85% -0.03%
==========================================
Files 291 291
Lines 21249 21249
==========================================
- Hits 15274 15269 -5
- Misses 4913 4918 +5
Partials 1062 1062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mstoykov
approved these changes
Jun 7, 2024
inancgumus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
k6/experimental/browserto the previous sync browser JS API.Why?
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)