Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved error message when missing import file #35

Closed
ragnarlonn opened this issue Dec 22, 2016 · 2 comments
Closed

improved error message when missing import file #35

ragnarlonn opened this issue Dec 22, 2016 · 2 comments

Comments

@ragnarlonn
Copy link

ragnarlonn commented Dec 22, 2016

JS-file:

import { Counter, Rate } from "k6/metrics";
import http from "k6/http";
import https from "jadaja/http";
:
:
:

yields:

time="2016-12-01T22:15:55Z" level=error msg="Couldn't create a runner" error="Error: open /go/src/github.com/loadimpact/k6/js/lib/jadaja/http.js: no such file or directory" 
Error: open /go/src/github.com/loadimpact/k6/js/lib/jadaja/http.js: no such file or directory
Davids-MacBook:samples davidrosen$ 

when file jadaja/http.js is missing.

Imported from https://trello.com/c/MX84A4Jp/111-improved-error-message-when-missing-import-file

@ragnarlonn
Copy link
Author

David Rosen
Seems like this error message overall can be improved.
It was just not obvious to me that k6/http implies an include file in .../k6/js/lib/jadaja/http.js
Dec 1 at 11:25 PM - Reply - Delete

Emily Ekberg
I think you mean import ... from "./jadaja/http.js"? Or do you mean that the error message for missing internal libraries isn't great?
Dec 1 at 11:20 PM - Reply - Delete

David Rosen
@uppfinnarn - not high prio, but adding card so we can track
Dec 1 at 11:19 PM - Reply - Delete

David Rosen
/cc @uppfinnarn
Dec 1 at 11:18 PM - Reply - Delete

@liclac liclac closed this as completed Apr 24, 2017
@liclac
Copy link
Contributor

liclac commented Apr 24, 2017

No longer an issue in the js2 runner, modules are handled separately from files.

mstoykov added a commit that referenced this issue Dec 18, 2024
* Warn on not setting binarytype

This is the first part of #35.

But even if #35 is not finished after this warning is an error we can
safely move this extension in k6.
olegbespalov pushed a commit that referenced this issue Jan 16, 2025
[1/3] Implement the `generateKey` operation with support for HMAC algorithm
codebien pushed a commit that referenced this issue Jan 27, 2025
chore: set folder structure like k6 repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants