Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce more specific error kinds #108

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Introduce more specific error kinds #108

merged 5 commits into from
Jul 30, 2024

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Jun 26, 2024

This is a draft addressing #100 (comment).

It introduces new error types for various error paths when using AWS client classes.

@oleiade oleiade requested a review from a team as a code owner June 26, 2024 13:21
@oleiade oleiade requested review from mstoykov and joanlopez and removed request for a team June 26, 2024 13:21
@oleiade oleiade marked this pull request as draft June 26, 2024 13:21
@oleiade oleiade requested review from codebien and removed request for mstoykov and joanlopez June 27, 2024 06:45
@oleiade
Copy link
Member Author

oleiade commented Jun 27, 2024

Adding you specifically @codebien in this draft stage as we came up with that design together 🤝 If you get a chance to take a look, I'd much appreciate your input on this 🙇🏻

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@oleiade oleiade force-pushed the error-types branch 2 times, most recently from 8f2f971 to 20fb397 Compare July 29, 2024 13:03
@oleiade oleiade changed the base branch from main to dependency_updates July 29, 2024 13:03
@oleiade oleiade marked this pull request as ready for review July 29, 2024 13:08
@oleiade oleiade requested a review from joanlopez July 29, 2024 13:09
@oleiade oleiade self-assigned this Jul 29, 2024
@oleiade oleiade added the enhancement New feature or request label Jul 29, 2024
@oleiade oleiade requested a review from codebien July 29, 2024 13:09
@oleiade oleiade force-pushed the dependency_updates branch from c6bf07b to f2b00ee Compare July 29, 2024 13:24
Base automatically changed from dependency_updates to main July 29, 2024 15:23
@oleiade oleiade changed the title WIP introduce more specific error kinds Introduce more specific error kinds Jul 29, 2024
src/internal/client.ts Outdated Show resolved Hide resolved
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@oleiade oleiade merged commit 8d9ef68 into main Jul 30, 2024
3 checks passed
@oleiade oleiade deleted the error-types branch July 30, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants