Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docker command in get started doc #1838

Merged
merged 2 commits into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sources/k6/next/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new

This is bash dependent, should we use instead $(id -u)? @oleiade Does it work for you on fish?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. In fish I have to quote "$ENV_VARIABLE", but --user "$UID" does work. Let's not bother too much about fish because it has its set of differences with standard shells like $(id -u) would be (id -u) anyway.

I do think switching to $(id -u) to be a good idea nonetheless anyway 👍🏻 (fish users will know what to do about it 🙇🏻

```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.48.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.49.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.50.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.51.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.52.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.53.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.54.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.55.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/k6/v0.56.x/get-started/running-k6.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ To run a simple local script:
```

```docker
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```windows
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ To run a simple local script:
```

```bash
$ docker run --rm -i -v $PWD:/app -w /app grafana/k6 new
$ docker run --rm -i --user $UID -v $PWD:/app -w /app grafana/k6 new
```

```bash
Expand Down
Loading