Explore: Update Loki labels when label selector is opened #16131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davkal
reviewed
Mar 21, 2019
| return Promise.all( | ||
| labelKeys.filter(key => DEFAULT_KEYS.indexOf(key) > -1).map(key => this.fetchLabelValues(key)) | ||
| ).then(values => { | ||
| this.logLabelFetchTs = Date.now(); |
There was a problem hiding this comment.
Race condition: logLabelFetchTs must be set before the requests start, otherwise a lot of requests can be started if refreshLogLabels is called quickly, assuming logLabelFetchTs has been set once (Date.now() - this.logLabelFetchTs > LABEL_REFRESH_INTERVAL with this.logLabelFetchTs being undefined masks this on the first run.
davkal
reviewed
Mar 22, 2019
hugohaggmark
approved these changes
Mar 22, 2019
dprokop
changed the title
aocenas
reviewed
Mar 23, 2019
| }); | ||
| setLogLabelOptions(nextOptions); // to set loading | ||
| fetchOptionValues(targetOption.value); | ||
| }, [activeOption]); |
There was a problem hiding this comment.
Maybe this should also fire when languageProviderInitialised is changed to true?
torkelo
approved these changes
Mar 25, 2019
torkelo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15402
This PR introduces possibility to refresh labels in Loki's language provider as well as enables refresh on UI level
Assumptions:
LABEL_REFRESH_INTERVALconst).rc-cascaderexposes, that is related to the UI interaction. What we can do to refresh not only on UI interaction is to implement effect inuseLokiLabelshook (see details below) that would refresh the labels in the background.Other changes:
LokiQueryFieldstate, thus made it a stateless component.useLokiLabels- performs missing options fetching and delegates refresh to language provideruseLokiSyntax- provides Loki's syntax to component that uses it, along with labels delivered byuseLokiLabelsSince this is a first time we are trying to use hooks in our code, the hooks implementation may not be the best on, just so you know;)
TODO:
LokiQueryFieldcomponentLokiQueryField