Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch: Fix view percentiles metric in table without date histogram #15686

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Elasticsearch: Fix view percentiles metric in table without date histogram #15686

merged 1 commit into from
Mar 29, 2019

Conversation

Ihor-Ratsuk
Copy link
Contributor

closes #3786

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Ihor-Ratsuk Ihor-Ratsuk force-pushed the fix-#3786 branch 2 times, most recently from 5b332ca to 53f1213 Compare February 27, 2019 11:31
marefr
marefr requested changes Mar 2, 2019
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Overall looks good.

However, comparing table using date histogram and without date histogram the selected metric of the percentile should be included in the column name.

image

@snowberrylee
Copy link

May I ask whether this change is included in grafana 6?
Can you also show me how to view percentiles in a non-time series table? (Just as your second table panel in your screenshot )

@marefr
Copy link
Member

marefr commented Mar 4, 2019

@snowberrylee this is an open pull request for adding the support as shown in the second table panel so no this is not included in Grafana 6.

@snowberrylee
Copy link

@marefr then is it possible for me to make use of this request currently?

@marefr
Copy link
Member

marefr commented Mar 4, 2019

@snowberrylee it's not that easy. You must checkout the authors branch and build Grafana from source

@snowberrylee
Copy link

@marefr Oh I see. What grafana version will be most likely to include this change?

@marefr
Copy link
Member

marefr commented Mar 4, 2019

@snowberrylee no ETA right now

@Yukinoshita-Yukino
Copy link
Contributor

This is awesome!
Just a question.
The changes are made on elastic_response.ts so I guess this will make alert on ES percentile values possible?

@marefr
Copy link
Member

marefr commented Mar 5, 2019

@Yukinoshita-Yukino alert on ES percentile using group by date histogram should already be working. This change fixes so that ES percentile without using date histogram can be properly visualized in table panel, but that's a tabular query which are not supported in alerting scenarios - only time series queries are.

@marefr
Copy link
Member

marefr commented Mar 26, 2019

@Igor-Ratsuk Have you had any change looking into my requested changes?

@Ihor-Ratsuk
Copy link
Contributor Author

Hello @marefr, I'm sorry for the delay, will update my PR today.

marefr
marefr approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@marefr marefr changed the title Elasticsearch table view Percentiles metric Elasticsearch: Support table view percentiles metric Mar 29, 2019
@marefr marefr changed the title Elasticsearch: Support table view percentiles metric Elasticsearch: Support table view percentiles metric without date histogram Mar 29, 2019
@marefr marefr changed the title Elasticsearch: Support table view percentiles metric without date histogram Elasticsearch: Fix view percentiles metric in table without date histogram Mar 29, 2019
@marefr marefr merged commit 930fd8b into grafana:master Mar 29, 2019
@marefr
Copy link
Member

marefr commented Mar 29, 2019

Thank you for contributing to Grafana!

@marefr marefr added this to the 6.2 milestone Mar 29, 2019
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into react-streaming
3806da8 
* grafana/master:
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
  Fix: Correct SnapshotData typing (grafana#16279)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into table-datasource
896f9b4 
* grafana/master:
  Fix: Bring back styles on Switch components when checked
  Update CHANGELOG.md
  Chore: breaks build if certain FrontEnd limits are exceeded (grafana#16301)
  Fix: Graphite query ast to string fix (grafana#16297)
  Fix: Template query editor this bind exception fix (grafana#16299)
  Fix: Alerting Notification channel http api fixes (grafana#16288)
  Refactor: Move LogLevel and Labels utils to @grafana/ui (grafana#16285)
  Refactor: Rename Tags to Labels in SeriesData (simple) (grafana#16284)
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into panel-in-view-from…
10d819f 
…-scroll-again

* grafana/master:
  Fix: Bring back styles on Switch components when checked
  Update CHANGELOG.md
  Chore: breaks build if certain FrontEnd limits are exceeded (grafana#16301)
  Fix: Graphite query ast to string fix (grafana#16297)
  Fix: Template query editor this bind exception fix (grafana#16299)
  Fix: Alerting Notification channel http api fixes (grafana#16288)
  Refactor: Move LogLevel and Labels utils to @grafana/ui (grafana#16285)
  Refactor: Rename Tags to Labels in SeriesData (simple) (grafana#16284)
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
  Fix: Correct SnapshotData typing (grafana#16279)
  Feat: Angular panels & SeriesData to Table/TimeSeries (grafana#16266)
  Fix: React Graph & Show message on no data (grafana#16278)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into clone-reference-panel
cb55609 
* grafana/master:
  Fix: Bring back styles on Switch components when checked
  Update CHANGELOG.md
  Chore: breaks build if certain FrontEnd limits are exceeded (grafana#16301)
  Fix: Graphite query ast to string fix (grafana#16297)
  Fix: Template query editor this bind exception fix (grafana#16299)
  Fix: Alerting Notification channel http api fixes (grafana#16288)
  Refactor: Move LogLevel and Labels utils to @grafana/ui (grafana#16285)
  Refactor: Rename Tags to Labels in SeriesData (simple) (grafana#16284)
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
  Fix: Correct SnapshotData typing (grafana#16279)
  Feat: Angular panels & SeriesData to Table/TimeSeries (grafana#16266)
  Fix: React Graph & Show message on no data (grafana#16278)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into dynamic-units
5e5d374 
* grafana/master: (102 commits)
  Fix: Bring back styles on Switch components when checked
  Update CHANGELOG.md
  Chore: breaks build if certain FrontEnd limits are exceeded (grafana#16301)
  Fix: Graphite query ast to string fix (grafana#16297)
  Fix: Template query editor this bind exception fix (grafana#16299)
  Fix: Alerting Notification channel http api fixes (grafana#16288)
  Refactor: Move LogLevel and Labels utils to @grafana/ui (grafana#16285)
  Refactor: Rename Tags to Labels in SeriesData (simple) (grafana#16284)
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
  Fix: Correct SnapshotData typing (grafana#16279)
  Feat: Angular panels & SeriesData to Table/TimeSeries (grafana#16266)
  Fix: React Graph & Show message on no data (grafana#16278)
  Feature: added actionable message in Explore when no datasource configured (grafana#16252)
  Feature: Case insensitive Loki search (grafana#15948)
  Feat: Singlestat panel react progress & refactorings (grafana#16039)
  Chore: Implement gosec (grafana#16261)
  Fix: Updated snapshot unit test that was failing
  Refactor: Theme & Removed the last rems (grafana#16245)
  ...
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into stats-filter
783cc20 
* grafana/master:
  Fix: Bring back styles on Switch components when checked
  Update CHANGELOG.md
  Chore: breaks build if certain FrontEnd limits are exceeded (grafana#16301)
  Fix: Graphite query ast to string fix (grafana#16297)
  Fix: Template query editor this bind exception fix (grafana#16299)
  Fix: Alerting Notification channel http api fixes (grafana#16288)
  Refactor: Move LogLevel and Labels utils to @grafana/ui (grafana#16285)
  Refactor: Rename Tags to Labels in SeriesData (simple) (grafana#16284)
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
  Fix: Correct SnapshotData typing (grafana#16279)
  Feat: Angular panels & SeriesData to Table/TimeSeries (grafana#16266)
  Fix: React Graph & Show message on no data (grafana#16278)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into expose-get-backend…
8e17d98 
…-srv

* grafana/master:
  Fix: Bring back styles on Switch components when checked
  Update CHANGELOG.md
  Chore: breaks build if certain FrontEnd limits are exceeded (grafana#16301)
  Fix: Graphite query ast to string fix (grafana#16297)
  Fix: Template query editor this bind exception fix (grafana#16299)
  Fix: Alerting Notification channel http api fixes (grafana#16288)
  Refactor: Move LogLevel and Labels utils to @grafana/ui (grafana#16285)
  Refactor: Rename Tags to Labels in SeriesData (simple) (grafana#16284)
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
  Fix: Correct SnapshotData typing (grafana#16279)
  Feat: Angular panels & SeriesData to Table/TimeSeries (grafana#16266)
  Fix: React Graph & Show message on no data (grafana#16278)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into jwt
c80f2b9 
* grafana/master:
  Fix: Bring back styles on Switch components when checked
  Update CHANGELOG.md
  Chore: breaks build if certain FrontEnd limits are exceeded (grafana#16301)
  Fix: Graphite query ast to string fix (grafana#16297)
  Fix: Template query editor this bind exception fix (grafana#16299)
  Fix: Alerting Notification channel http api fixes (grafana#16288)
  Refactor: Move LogLevel and Labels utils to @grafana/ui (grafana#16285)
  Refactor: Rename Tags to Labels in SeriesData (simple) (grafana#16284)
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
  Fix: Correct SnapshotData typing (grafana#16279)
  Feat: Angular panels & SeriesData to Table/TimeSeries (grafana#16266)
  Fix: React Graph & Show message on no data (grafana#16278)
ryantxu added a commit to ryantxu/grafana that referenced this pull request Mar 29, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into timepicker-tooltip
aaf0a18 
* grafana/master: (608 commits)
  Fix: Bring back styles on Switch components when checked
  Update CHANGELOG.md
  Chore: breaks build if certain FrontEnd limits are exceeded (grafana#16301)
  Fix: Graphite query ast to string fix (grafana#16297)
  Fix: Template query editor this bind exception fix (grafana#16299)
  Fix: Alerting Notification channel http api fixes (grafana#16288)
  Refactor: Move LogLevel and Labels utils to @grafana/ui (grafana#16285)
  Refactor: Rename Tags to Labels in SeriesData (simple) (grafana#16284)
  Elasticsearch: Fix view percentiles metric in table without date histogram (grafana#15686)
  Configuration: Improve session_lifetime comments (grafana#16238)
  Alerting: Makes timeouts and retries configurable (grafana#16259)
  Fix: Correct SnapshotData typing (grafana#16279)
  Feat: Angular panels & SeriesData to Table/TimeSeries (grafana#16266)
  Fix: React Graph & Show message on no data (grafana#16278)
  Feature: added actionable message in Explore when no datasource configured (grafana#16252)
  Feature: Case insensitive Loki search (grafana#15948)
  Feat: Singlestat panel react progress & refactorings (grafana#16039)
  Chore: Implement gosec (grafana#16261)
  Fix: Updated snapshot unit test that was failing
  Refactor: Theme & Removed the last rems (grafana#16245)
  ...
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marefr marefr marefr approved these changes

Assignees
No one assigned
Labels
add to changelog pr/external This PR is from external contributor type/bug
Projects
None yet
Milestone
6.2-beta1
Development

Successfully merging this pull request may close these issues.

Elasticsearch table view Percentiles metric
6 participants
@Ihor-Ratsuk @CLAassistant @snowberrylee @marefr @Yukinoshita-Yukino @ying-jeanne