Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IPv6 in Auth proxy white list #11330

Merged
merged 1 commit into from
Mar 28, 2018
Merged

Support IPv6 in Auth proxy white list #11330

merged 1 commit into from
Mar 28, 2018

Conversation

corny
Copy link
Contributor

@corny corny commented Mar 21, 2018

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Mar 21, 2018 •
edited
Loading

Codecov Report

Merging #11330 into master will decrease coverage by 0.39%.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##           master   #11330     +/-   ##
=========================================
- Coverage    51.8%   51.41%   -0.4%     
=========================================
  Files         359      354      -5     
  Lines       26019    25613    -406     
  Branches     1556     1494     -62     
=========================================
- Hits        13480    13169    -311     
+ Misses      11794    11707     -87     
+ Partials      745      737      -8

@corny corny mentioned this pull request Mar 22, 2018
Closed
@bergquist
Copy link
Contributor

needs rebasing due to golint PR.

@corny
Copy link
Contributor Author

corny commented Mar 23, 2018

Done

@corny
Use net.SplitHostPort to support IPv6
391868c 
- Add some tests
- Make error message more helpful
@bergquist bergquist added this to the 5.1 milestone Mar 28, 2018
@bergquist bergquist changed the title Use net.SplitHostPort to support IPv6 Support IPv6 in Auth proxy Mar 28, 2018
@bergquist bergquist changed the title Support IPv6 in Auth proxy Support IPv6 in Auth proxy white list Mar 28, 2018
@bergquist bergquist merged commit f009443 into grafana:master Mar 28, 2018
@corny
Copy link
Contributor Author

corny commented Mar 28, 2018

Thanks a lot!

@corny corny deleted the auth-ipv6 branch March 28, 2018 13:16
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergquist bergquist bergquist approved these changes

Assignees
No one assigned
Labels
pr/external This PR is from external contributor
Projects
None yet
Milestone
5.1-beta1
Development

Successfully merging this pull request may close these issues.
5 participants
@corny @CLAassistant @codecov-io @bergquist @ying-jeanne