Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full screen state should be serialized in url #672

Closed
clkao opened this issue Aug 9, 2014 · 5 comments
Closed

full screen state should be serialized in url #672

clkao opened this issue Aug 9, 2014 · 5 comments
Labels
area/dashboard
Milestone
v1.8.0

Comments

@clkao
Copy link
Contributor

clkao commented Aug 9, 2014

when a pane is turned into fullscreen, we should update the url to represent such state, so sharing the url will load the particular pane only.
@torkelo torkelo added this to the v1.8.0 milestone Aug 10, 2014
@sahilthapar
Copy link

👍

1 similar comment
@nikicat
Copy link
Contributor

nikicat commented Aug 11, 2014

👍

torkelo added a commit that referenced this issue Aug 12, 2014
@torkelo
Working on linking to panels, #576, #672
d46e612
torkelo added a commit that referenced this issue Aug 13, 2014
@torkelo
Fullscreen & edit state persisted to url is nearing completion, refac…
fc686ca 
…tored fullscreen state management to a special dashboardViewState object, Issue #672
torkelo added a commit that referenced this issue Aug 13, 2014
@torkelo
Panel edit state is working pretty good now, #672
4d1102d
torkelo added a commit that referenced this issue Aug 13, 2014
@torkelo
final fixes for fullscreen url state, #672
dee0e5f
torkelo added a commit that referenced this issue Aug 13, 2014
@torkelo
Updated changelog with #672
ce6b606
@torkelo torkelo closed this as completed Aug 13, 2014
@torkelo
Copy link
Member

torkelo commented Aug 13, 2014

This is now implemented. Incredibly complicated! Grafana handles fullscreen in a special way for perfomance reasons so you can quickly jump to edit and back to the dashboard. This issue was very tricky to do without triggering a full dashboard / view reload. But I think all scenarios I can think of now work (back/forward in the browser, refreshing/reloading, sharing link in the browser).

@clkao
Copy link
Contributor Author

clkao commented Aug 13, 2014

@torkelo++ This is working beautifully!

@torkelo
Copy link
Member

torkelo commented Aug 13, 2014

@clkao great! Took me for ever to get right.

Something that I did not mention is that this feature required a small schema upgrade. Panels now require an id. If they do not have an id they will be assigned one on dashboard load. The id is an incrementing number, but once assigned it will not change. Originally I thought I could use the panel title but this is not ideal as you can have many panels with the same title and if you later did a small panel rename then links to it would break.

@dpkp dpkp mentioned this issue Aug 21, 2014
Closed
torkelo added a commit that referenced this issue Aug 21, 2014
@torkelo
Fix for reloadOnSearch missing on all dashboard routes, caused dashbo…
7c3046e 
…ard to be reloaded when entering/exiting edit mode (settings were lost), related to recent fullscreen/edit state present in url, #672, #425
@blackwithwhite666 blackwithwhite666 mentioned this issue Oct 17, 2014
Closed
sunker pushed a commit that referenced this issue Nov 28, 2022
@sarahzinger
Add Latest SDK (#672)
1801549
sunker pushed a commit that referenced this issue Nov 28, 2022
@sarahzinger @sunker
Add Latest SDK (#672)
707447a
sunker added a commit that referenced this issue Nov 28, 2022
@sunker @sarahzinger
@fridgepoet @GrafanaWriter
CloudWatch: Cross-account querying support (#59362)
254577b 
* Lattice: Point to private prerelease of aws-sdk-go (#515)

* point to private prerelease of aws-sdk-go

* fix build issue

* Lattice: Adding a feature toggle (#549)

* Adding a feature toggle for lattice

* Change name of feature toggle

* Lattice: List accounts (#543)

* Separate layers

* Introduce testify/mock library

Co-authored-by: Shirley Leu <4163034+fridgepoet@users.noreply.github.com>

* point to version that includes metric api changes (#574)

* add accounts component (#575)

* Test refactor: remove unneeded clientFactoryMock (#581)

* Lattice: Add monitoring badge (#576)

* add monitoring badge

* fix tests

* solve conflict

* Lattice: Add dynamic label for account display name (#579)

* Build: Automatically sync lattice-main with OSS

* Lattice: Point to private prerelease of aws-sdk-go (#515)

* point to private prerelease of aws-sdk-go

* fix build issue

* Lattice: Adding a feature toggle (#549)

* Adding a feature toggle for lattice

* Change name of feature toggle

* Lattice: List accounts (#543)

* Separate layers

* Introduce testify/mock library

Co-authored-by: Shirley Leu <4163034+fridgepoet@users.noreply.github.com>

* point to version that includes metric api changes (#574)

* add accounts component (#575)

* Test refactor: remove unneeded clientFactoryMock (#581)

* Lattice: Add monitoring badge (#576)

* add monitoring badge

* fix tests

* solve conflict

* add account label

Co-authored-by: Shirley Leu <4163034+fridgepoet@users.noreply.github.com>
Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>

* fix import

* solve merge related problem

* add account info (#608)

* add back namespaces handler

* Lattice: Parse account id and return it to frontend (#609)

* parse account id and return to frontend

* fix route test

* only show badge when feature toggle is enabled (#615)

* Lattice: Refactor resource response type and return account (#613)

* refactor resource response type

* remove not used file.

* go lint

* fix tests

* remove commented code

* Lattice: Use account as input when listing metric names and dimensions (#611)

* use account in resource requests

* add account to response

* revert accountInfo to accountId

* PR feedback

* unit test account in list metrics response

* remove not used asserts

* don't assert on response that is not relevant to the test

* removed dupe test

* pr feedback

* rename request package (#626)

* Lattice: Move account component and add tooltip (#630)

* move accounts component to the top of metric stat editor

* add tooltip

* CloudWatch: add account to GetMetricData queries (#627)

* Add AccountId to metric stat query

* Lattice: Account variable support  (#625)

* add variable support in accounts component

* add account variable query type

* update variables

* interpolate variable before its sent to backend

* handle variable change in hooks

* remove not used import

* Update public/app/plugins/datasource/cloudwatch/components/Account.tsx

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>

* Update public/app/plugins/datasource/cloudwatch/hooks.ts

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>

* add one more unit test

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>

* cleanup (#629)

* Set account Id according to crossAccountQuerying feature flag in backend (#632)

* CloudWatch: Change spelling of feature-toggle (#634)

* Lattice Logs (#631)

* Lattice Logs

* Fixes after CR

* Lattice: Bug: fix dimension keys request (#644)

* fix dimension keys

* fix lint

* more lint

* CloudWatch: Add tests for QueryData with AccountId (#637)

* Update from breaking change (#645)

* Update from breaking change

* Remove extra interface and methods

Co-authored-by: Shirley Leu <4163034+fridgepoet@users.noreply.github.com>

* CloudWatch: Add business logic layer for getting log groups (#642)



Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>

* Lattice: Fix - unset account id in region change handler (#646)

* move reset of account to region change handler

* fix broken test

* Lattice: Add account id to metric stat query deep link (#656)

add account id to metric stat link

* CloudWatch: Add new log groups handler for cross-account querying (#643)

* Lattice: Add feature tracking (#660)

* add tracking for account id prescense in metrics query

* also check feature toggle

* fix broken test

* CloudWatch: Add route for DescribeLogGroups for cross-account querying (#647)

Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>

* Lattice: Handle account id default value (#662)

* make sure right type is returned

* set right default values

* Suggestions to lattice changes (#663)

* Change ListMetricsWithPageLimit response to slice of non-pointers

* Change GetAccountsForCurrentUserOrRole response to be not pointer

* Clean test Cleanup calls in test

* Remove CloudWatchAPI as part of mock

* Resolve conflicts

* Add Latest SDK (#672)

* add tooltip (#674)

* Docs: Add documentation for CloudWatch cross account querying (#676)

* wip docs

* change wordings

* add sections about metrics and logs

* change from monitoring to observability

* Update docs/sources/datasources/aws-cloudwatch/_index.md

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>

* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md

Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>

* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md

Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>

* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>

* Update docs/sources/datasources/aws-cloudwatch/query-editor/index.md

Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>

* apply pr feedback

* fix file name

* more pr feedback

* pr feedback

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>
Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>

* use latest version of the aws-sdk-go

* Fix tests' mock response type

* Remove change in Azure Monitor

Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>
Co-authored-by: Shirley Leu <4163034+fridgepoet@users.noreply.github.com>
Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
4 participants
@torkelo @clkao @nikicat @sahilthapar