Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags filter dropdown selector is not scrollable #14486

Closed
cdanis opened this issue Dec 13, 2018 · 7 comments
Closed

Tags filter dropdown selector is not scrollable #14486

cdanis opened this issue Dec 13, 2018 · 7 comments
Assignees
Milestone

Comments

@cdanis
Copy link

cdanis commented Dec 13, 2018

Using Grafana 5.4.1* running on Debian Stretch.

In the dashboard finder UI (obtained by clicking the top nav bar), the tags filter dropdown list is not scrollable -- there's no scrollbar, and mouse wheel doesn't do anything either. We have many tags, so between this and #14437, it's basically impossible to select any tag aside from the first few.

image

*: Just saw that 5.4.2 is released and about upgrade to it -- thanks for the quick fix on #14437!

@daniellee
Copy link
Contributor

Confirmed. Thanks for reporting this (again!).

@daniellee daniellee added this to the 5.5 milestone Dec 14, 2018
@jschill
Copy link
Contributor

jschill commented Dec 19, 2018

Hey! This is fixed in master per 7e0bc8f

We could (should) cherry pick it if a 5.4.3 is released.

@jschill
Copy link
Contributor

jschill commented Dec 19, 2018

Closing. Thanks for reporting!

@jschill jschill closed this as completed Dec 19, 2018
@marefr
Copy link
Member

marefr commented Dec 19, 2018

@jschill given a lot of refactorings have been made to the react select drop down in master, is it really a matter of cherry picking that commit or is it more changes needed?

@jschill
Copy link
Contributor

jschill commented Dec 19, 2018

@marefr I'm not sure what else has been done/refactored. We could look into that if a patch release should be reality.

@marefr
Copy link
Member

marefr commented Dec 19, 2018

Hmm okay. Sure

@jschill
Copy link
Contributor

jschill commented Dec 19, 2018

Well, we could of course skip it and have it in 5.5 instead if we think it's a mess cherry picking.

ryantxu added a commit to ryantxu/grafana that referenced this issue Dec 19, 2018
* grafana/master: (41 commits)
  Fixes undefined issue with angular panels and editorTabs
  changelog: adds note about closing grafana#14562
  Update field name
  Add documentation
  Rename the setting and add description
  export init notifier func
  Increase recent and starred limit in search and home dashboard, closes grafana#13950
  changelog: adds note about closing grafana#14486
  Panel help view fixes
  Add min/max height when resizing and replace debounce with throttle
  changelog: adds note about closing grafana#14546
  Adding tests for auth proxy CIDR support
  changelog: adds note about closing grafana#14109
  fix signed in user for orgId=0 result should return active org id
  Another take on resizing the panel, now using react-draggable
  Raise datasources number to 5000
  copy props to state to make it visible in the view
  refactor to not crash when no links
  updating snaps
  renaming component
  ...
ryantxu added a commit to ryantxu/grafana that referenced this issue Dec 19, 2018
* grafana/master: (2079 commits)
  Fixes undefined issue with angular panels and editorTabs
  changelog: adds note about closing grafana#14562
  Update field name
  Add documentation
  Rename the setting and add description
  export init notifier func
  Increase recent and starred limit in search and home dashboard, closes grafana#13950
  changelog: adds note about closing grafana#14486
  Panel help view fixes
  Add min/max height when resizing and replace debounce with throttle
  changelog: adds note about closing grafana#14546
  Adding tests for auth proxy CIDR support
  changelog: adds note about closing grafana#14109
  fix signed in user for orgId=0 result should return active org id
  Another take on resizing the panel, now using react-draggable
  Raise datasources number to 5000
  copy props to state to make it visible in the view
  refactor to not crash when no links
  updating snaps
  renaming component
  ...
@torkelo torkelo modified the milestones: 5.5, 6.0-beta1 Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants