Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml whitespace in plugin installation documentation example #658

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

ptrbp
Copy link
Contributor

@ptrbp ptrbp commented Dec 30, 2021

Description

Minor fix for plugin installation using env vars documentation example.

name should be a child of secretRef.

Without the fix:

error: error validating "STDIN": error validating data: ValidationError(Grafana.spec.deployment.envFrom[0]): unknown field "name" in org.integreatly.v1alpha1.Grafana.spec.deployment.envFrom; if you choose to ignore these errors, turn validation off with --validate=false

Type of change

Documentation fix

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Copy link
Collaborator

@hubeadmin hubeadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, nice catch! we love it when the community catches things like this!

@hubeadmin hubeadmin merged commit bd7fa36 into grafana:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants